[libc] Restore DECLS_FILE_PATH property #99583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DECLS_FILE_PATH property is supposed to be set on the targets for the generated headers for the GPU build installation. It got missed when creating the cmake rule for new headergen.
jhuber6
approved these changes
Jul 18, 2024
|
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesThe DECLS_FILE_PATH property is supposed to be set on the targets for Full diff: https://github.com/llvm/llvm-project/pull/99583.diff 1 Files Affected:
diff --git a/libc/cmake/modules/LLVMLibCHeaderRules.cmake b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
index 91054810f5ec5..3049f4db7301f 100644
--- a/libc/cmake/modules/LLVMLibCHeaderRules.cmake
+++ b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
@@ -160,6 +160,7 @@ function(add_gen_header2 target_name)
${fq_target_name}
PROPERTIES
HEADER_FILE_PATH ${out_file}
+ DECLS_FILE_PATH "${decl_out_file}"
DEPS "${fq_deps_list}"
)
|
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: The DECLS_FILE_PATH property is supposed to be set on the targets for the generated headers for the GPU build installation. It got missed when creating the cmake rule for new headergen. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DECLS_FILE_PATH property is supposed to be set on the targets for
the generated headers for the GPU build installation. It got missed when
creating the cmake rule for new headergen.