Skip to content

[libc] Add AMDGPU Timing to CMake #99603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jameshu15869
Copy link
Contributor

libc/benchmarks/gpu/timing/CMakeLists.txt did not correctly build amdgpu utils. This PR fixes that issue by adding amdgpu to the loop that adds the correct sub directories.

@llvmbot llvmbot added the libc label Jul 19, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 19, 2024

@llvm/pr-subscribers-libc

Author: None (jameshu15869)

Changes

libc/benchmarks/gpu/timing/CMakeLists.txt did not correctly build amdgpu utils. This PR fixes that issue by adding amdgpu to the loop that adds the correct sub directories.


Full diff: https://github.com/llvm/llvm-project/pull/99603.diff

1 Files Affected:

  • (modified) libc/benchmarks/gpu/timing/CMakeLists.txt (+1-1)
diff --git a/libc/benchmarks/gpu/timing/CMakeLists.txt b/libc/benchmarks/gpu/timing/CMakeLists.txt
index 8bbc7e33f122a..b6d84607aa607 100644
--- a/libc/benchmarks/gpu/timing/CMakeLists.txt
+++ b/libc/benchmarks/gpu/timing/CMakeLists.txt
@@ -1,4 +1,4 @@
-foreach(target nvptx)
+foreach(target nvptx amdgpu)
   add_subdirectory(${target})
   list(APPEND target_gpu_timing libc.benchmarks.gpu.timing.${target}.${target}_timing)
 endforeach()

@jhuber6 jhuber6 merged commit ef47bbb into llvm:main Jul 19, 2024
8 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 19, 2024

LLVM Buildbot has detected a new failure on builder openmp-offload-libc-amdgpu-runtime running on omp-vega20-1 while building libc at step 10 "Add check check-offload".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/2201

Here is the relevant piece of the build log for the reference:

Step 10 (Add check check-offload) failure: 1200 seconds without output running [b'ninja', b'-j 32', b'check-offload'], attempting to kill
...
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/thread_state_1.c (778 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/bug47654.cpp (779 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/bug50022.cpp (780 of 789)
PASS: libomptarget :: amdgcn-amd-amdhsa :: offloading/bug49021.cpp (781 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/wtime.c (782 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu :: offloading/bug49021.cpp (783 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu :: offloading/std_complex_arithmetic.cpp (784 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/complex_reduction.cpp (785 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/bug49021.cpp (786 of 789)
PASS: libomptarget :: x86_64-pc-linux-gnu-LTO :: offloading/std_complex_arithmetic.cpp (787 of 789)
command timed out: 1200 seconds without output running [b'ninja', b'-j 32', b'check-offload'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1227.853281

yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
`libc/benchmarks/gpu/timing/CMakeLists.txt` did not correctly build
`amdgpu` utils. This PR fixes that issue by adding `amdgpu` to the loop
that adds the correct sub directories.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants