[TOSA] Add lowering for tosa.sin and tosa.cos
#99651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower tosa ops to `mlir::math::SinOp` and `mlir::math::CosOp` as part of the tosa to linalg conversion. Added lit tests for conversion.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-linalg Author: Dhruv Chauhan (dchauhan-arm) ChangesLower tosa ops to Full diff: https://github.com/llvm/llvm-project/pull/99651.diff 2 Files Affected:
diff --git a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
index 1442f2ad72255..ba259d4b84fce 100644
--- a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
+++ b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
@@ -298,6 +298,14 @@ static Value createLinalgBodyCalculationForElementwiseOp(
if (isa<tosa::ExpOp>(op) && isa<FloatType>(elementTy))
return rewriter.create<mlir::math::ExpOp>(loc, resultTypes, args);
+ // tosa::SinOp
+ if (isa<tosa::SinOp>(op) && isa<FloatType>(elementTy))
+ return rewriter.create<mlir::math::SinOp>(loc, resultTypes, args);
+
+ // tosa::CosOp
+ if (isa<tosa::CosOp>(op) && isa<FloatType>(elementTy))
+ return rewriter.create<mlir::math::CosOp>(loc, resultTypes, args);
+
// tosa::TanhOp
if (isa<tosa::TanhOp>(op) && isa<FloatType>(elementTy))
return rewriter.create<mlir::math::TanhOp>(loc, resultTypes, args);
@@ -2598,6 +2606,8 @@ void mlir::tosa::populateTosaToLinalgConversionPatterns(
PointwiseConverter<tosa::LogOp>,
PointwiseConverter<tosa::ExpOp>,
PointwiseConverter<tosa::AbsOp>,
+ PointwiseConverter<tosa::SinOp>,
+ PointwiseConverter<tosa::CosOp>,
PointwiseConverter<tosa::TanhOp>,
PointwiseConverter<tosa::ErfOp>,
PointwiseConverter<tosa::BitwiseAndOp>,
diff --git a/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir b/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir
index 5187d79fd4c0b..4fe6b159fe443 100644
--- a/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir
+++ b/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir
@@ -545,6 +545,14 @@ func.func @test_simple_f32(%arg0: tensor<1xf32>) -> () {
// CHECK: math.erf
%24 = tosa.erf %0 : (tensor<1xf32>) -> tensor<1xf32>
+ // CHECK: linalg.generic
+ // CHECK: sin
+ %25 = tosa.sin %arg0 : (tensor<1xf32>) -> tensor<1xf32>
+
+ // CHECK: linalg.generic
+ // CHECK: cos
+ %26 = tosa.cos %arg0 : (tensor<1xf32>) -> tensor<1xf32>
+
return
}
|
|
LGTM. |
Hsiangkai
approved these changes
Jul 19, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Lower tosa ops to `mlir::math::SinOp` and `mlir::math::CosOp` as part of the tosa to linalg conversion. Added lit tests for conversion. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower tosa ops to
mlir::math::SinOpandmlir::math::CosOpas part of the tosa to linalg conversion.Added lit tests for conversion.