-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[compiler-rt] dump registers for FreeBSD/i386 #99702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-compiler-rt-sanitizer Author: David CARLIER (devnexen) ChangesFull diff: https://github.com/llvm/llvm-project/pull/99702.diff 2 Files Affected:
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
index 40c46a8949636..6691a814f82c5 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
@@ -2262,6 +2262,18 @@ void SignalContext::DumpAllRegisters(void *context) {
Printf("r14 = 0x%016llx ", ucontext->uc_mcontext.mc_r14);
Printf("r15 = 0x%016llx ", ucontext->uc_mcontext.mc_r15);
Printf("\n");
+# elif defined(__i386__)
+ Report("Register values:\n");
+ Printf("eax = 0x%016llx ", ucontext->uc_mcontext.mc_eax);
+ Printf("ebx = 0x%016llx ", ucontext->uc_mcontext.mc_ebx);
+ Printf("ecx = 0x%016llx ", ucontext->uc_mcontext.mc_ecx);
+ Printf("edx = 0x%016llx ", ucontext->uc_mcontext.mc_edx);
+ Printf("\n");
+ Printf("edi = 0x%016llx ", ucontext->uc_mcontext.mc_edi);
+ Printf("esi = 0x%016llx ", ucontext->uc_mcontext.mc_esi);
+ Printf("ebp = 0x%016llx ", ucontext->uc_mcontext.mc_ebp);
+ Printf("esp = 0x%016llx ", ucontext->uc_mcontext.mc_esp);
+ Printf("\n");
# else
(void)ucontext;
# endif
diff --git a/compiler-rt/test/sanitizer_common/TestCases/FreeBSD/dump_registers_i386.cpp b/compiler-rt/test/sanitizer_common/TestCases/FreeBSD/dump_registers_i386.cpp
new file mode 100644
index 0000000000000..74aea4d8b360a
--- /dev/null
+++ b/compiler-rt/test/sanitizer_common/TestCases/FreeBSD/dump_registers_i386.cpp
@@ -0,0 +1,17 @@
+// Check that sanitizer prints registers dump_registers on dump_registers=1
+// RUN: %clangxx %s -o %t
+// RUN: %env_tool_opts=dump_registers=0 not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK-NODUMP --strict-whitespace
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK-DUMP --strict-whitespace
+//
+// REQUIRES: i386-target-arch
+
+#include <signal.h>
+
+int main() {
+ raise(SIGSEGV);
+ // CHECK-DUMP: Register values
+ // CHECK-DUMP-NEXT: eax = {{0x[0-9a-f]+}} ebx = {{0x[0-9a-f]+}} ecx = {{0x[0-9a-f]+}} edx = {{0x[0-9a-f]+}}
+ // CHECK-DUMP-NEXT: edi = {{0x[0-9a-f]+}} esi = {{0x[0-9a-f]+}} ebp = {{0x[0-9a-f]+}} esp = {{0x[0-9a-f]+}}
+ // CHECK-NODUMP-NOT: Register values
+ return 0;
+}
|
@@ -2262,6 +2262,18 @@ void SignalContext::DumpAllRegisters(void *context) { | |||
Printf("r14 = 0x%016llx ", ucontext->uc_mcontext.mc_r14); | |||
Printf("r15 = 0x%016llx ", ucontext->uc_mcontext.mc_r15); | |||
Printf("\n"); | |||
# elif defined(__i386__) | |||
Report("Register values:\n"); | |||
Printf("eax = 0x%016llx ", ucontext->uc_mcontext.mc_eax); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for 32bit it should be 8char aligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix format to use 8 char
059ec3e
to
b1b65ad
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251263
No description provided.