M68k: Remove hasDebugInfo check when deciding to emit CFI #99750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-backend-m68k Author: Matt Arsenault (arsenm) ChangesNo other target checks this, and this is untested. I am trying Full diff: https://github.com/llvm/llvm-project/pull/99750.diff 1 Files Affected:
diff --git a/llvm/lib/Target/M68k/M68kFrameLowering.cpp b/llvm/lib/Target/M68k/M68kFrameLowering.cpp
index 36443f9d33451..a609be08d3021 100644
--- a/llvm/lib/Target/M68k/M68kFrameLowering.cpp
+++ b/llvm/lib/Target/M68k/M68kFrameLowering.cpp
@@ -246,9 +246,8 @@ MachineBasicBlock::iterator M68kFrameLowering::eliminateCallFramePseudoInstr(
unsigned StackAlign = getStackAlignment();
Amount = alignTo(Amount, StackAlign);
- MachineModuleInfo &MMI = MF.getMMI();
const auto &Fn = MF.getFunction();
- bool DwarfCFI = MMI.hasDebugInfo() || Fn.needsUnwindTableEntry();
+ bool DwarfCFI = Fn.needsUnwindTableEntry();
// If we have any exception handlers in this function, and we adjust
// the SP before calls, we may need to indicate this to the unwinder
|
arsenm
requested review from
0x59616e,
jrtc27,
MaskRay,
mshockwave,
rengolin,
ricky26,
RKSimon,
rnk,
s-barannikov and
tclin914
No other target checks this directly, and this is untested. Use needsFrameMoves, which covers both conditions already and is what most other targets consider.
| const auto &Fn = MF.getFunction(); | ||
| bool DwarfCFI = MMI.hasDebugInfo() || Fn.needsUnwindTableEntry(); | ||
| bool DwarfCFI = Fn.needsUnwindTableEntry(); |
There was a problem hiding this comment.
I believe most of M68k's frame lowering was adapted from X86, and the corresponding line was changed by this commit to MF.needsFrameMoves(). I'm not sure this is the correct method to use, but at least using it would be consistent.
By the way, needsFrameMoves calls MF.getMMI(). Is there a plan on how to get rid of this call?
arsenm
force-pushed
the
users/arsenm/m68k-remove-mmi-hasdebuginfo-check
branch
from
23815a3 to
35126c1
Compare
s-barannikov
approved these changes
Jul 20, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: No other target checks this, and this is untested. I am trying to remove the MachineModuleInfo reference from MachineFunction, and this is the stickiest blocker. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No other target checks this, and this is untested. I am trying
to remove the MachineModuleInfo reference from MachineFunction,
and this is the stickiest blocker.