[SandboxIR] Implement ReturnInst #99784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmsri
reviewed
Jul 22, 2024
llvm/lib/SandboxIR/SandboxIR.cpp
Outdated
| @@ -540,6 +540,48 @@ void StoreInst::dump() const { | |||
| dump(dbgs()); | |||
| dbgs() << "\n"; | |||
| } | |||
| #endif // NDEBUG | |||
|
|
|||
| Value *ReturnInst::create(Value *RetVal, Instruction *InsertBefore, | |||
There was a problem hiding this comment.
Return type should be ReturnInst * to be consistent with definition and other create*Inst()
There was a problem hiding this comment.
Ah yes, in this case we can return RetunInst *. In some other cases it gets folded by the IRBuilder, but not here.
tmsri
reviewed
Jul 22, 2024
tmsri
reviewed
Jul 22, 2024
tmsri
reviewed
Jul 22, 2024
tmsri
approved these changes
Jul 22, 2024
This patch add the implementation of the SandboxIR ReturnInst which mirrors llvm::ReturnInst.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This patch adds the implementation of the SandboxIR ReturnInst which mirrors llvm::ReturnInst. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add the implementation of the SandboxIR ReturnInst which mirrors llvm::ReturnInst.