[compiler-rt] Check codesign in path before using #99837
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroelofs
reviewed
Jul 22, 2024
Fixes an issue discovered with Nix where codesign is executed but Nix cannot use codesign without faults. Use `find_program` in CMake to ensure it is in `$PATH`.
RossComputerGuy
force-pushed
the
feat/compiler-rt-no-codesign
branch
from
e84b12e to
14ae0a6
Compare
jroelofs
approved these changes
Jul 22, 2024
|
would be great if this was merged. thx! |
|
Well, I got merge perms recently now so I guess no harm if I merge it myself then? |
|
Sorry, I should have followed up and asked if you needed help merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue discovered with Nix where codesign is executed but Nix cannot use codesign without faults. Use
find_programin CMake to ensure it is in$PATH.Can be tested on macOS and change your path in such a way that
codesignisn't in it.Related: NixOS/nixpkgs#329058