[clang][CodeGen] Don't crash on output whose size is zero. #99849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetingk
requested review from
nikic,
yuanfang-chen,
phoebewang,
labrinea and
topperc
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-codegen Author: Yeting Kuo (yetingk) ChangesThis fixes issue #63878 caused by creating an integer with zero bitwidth. Full diff: https://github.com/llvm/llvm-project/pull/99849.diff 2 Files Affected:
diff --git a/clang/lib/CodeGen/CGStmt.cpp b/clang/lib/CodeGen/CGStmt.cpp
index aa97f685ac7a9..92955e6cf4c96 100644
--- a/clang/lib/CodeGen/CGStmt.cpp
+++ b/clang/lib/CodeGen/CGStmt.cpp
@@ -2751,7 +2751,10 @@ void CodeGenFunction::EmitAsmStmt(const AsmStmt &S) {
if (RequiresCast) {
unsigned Size = getContext().getTypeSize(QTy);
- Ty = llvm::IntegerType::get(getLLVMContext(), Size);
+ if (Size)
+ Ty = llvm::IntegerType::get(getLLVMContext(), Size);
+ else
+ CGM.Error(S.getAsmLoc(), "Output operand is sizeless!");
}
ResultRegTypes.push_back(Ty);
// If this output is tied to an input, and if the input is larger, then
diff --git a/clang/test/CodeGen/inline-asm-sizeless.c b/clang/test/CodeGen/inline-asm-sizeless.c
new file mode 100644
index 0000000000000..29c1fc5b0b8f7
--- /dev/null
+++ b/clang/test/CodeGen/inline-asm-sizeless.c
@@ -0,0 +1,7 @@
+// RUN: not %clang_cc1 -S %s -o /dev/null 2>&1 | FileCheck %s
+
+// CHECK: error: Output operand is sizeless!
+void foo(void) {
+ extern long bar[];
+ asm ("" : "=r"(bar));
+}
|
|
@llvm/pr-subscribers-clang Author: Yeting Kuo (yetingk) ChangesThis fixes issue #63878 caused by creating an integer with zero bitwidth. Full diff: https://github.com/llvm/llvm-project/pull/99849.diff 2 Files Affected:
diff --git a/clang/lib/CodeGen/CGStmt.cpp b/clang/lib/CodeGen/CGStmt.cpp
index aa97f685ac7a9..92955e6cf4c96 100644
--- a/clang/lib/CodeGen/CGStmt.cpp
+++ b/clang/lib/CodeGen/CGStmt.cpp
@@ -2751,7 +2751,10 @@ void CodeGenFunction::EmitAsmStmt(const AsmStmt &S) {
if (RequiresCast) {
unsigned Size = getContext().getTypeSize(QTy);
- Ty = llvm::IntegerType::get(getLLVMContext(), Size);
+ if (Size)
+ Ty = llvm::IntegerType::get(getLLVMContext(), Size);
+ else
+ CGM.Error(S.getAsmLoc(), "Output operand is sizeless!");
}
ResultRegTypes.push_back(Ty);
// If this output is tied to an input, and if the input is larger, then
diff --git a/clang/test/CodeGen/inline-asm-sizeless.c b/clang/test/CodeGen/inline-asm-sizeless.c
new file mode 100644
index 0000000000000..29c1fc5b0b8f7
--- /dev/null
+++ b/clang/test/CodeGen/inline-asm-sizeless.c
@@ -0,0 +1,7 @@
+// RUN: not %clang_cc1 -S %s -o /dev/null 2>&1 | FileCheck %s
+
+// CHECK: error: Output operand is sizeless!
+void foo(void) {
+ extern long bar[];
+ asm ("" : "=r"(bar));
+}
|
| @@ -0,0 +1,7 @@ | |||
| // RUN: not %clang_cc1 -S %s -o /dev/null 2>&1 | FileCheck %s | |||
There was a problem hiding this comment.
Please use "-verify" to check clang diagnostics, not FileCheck.
Is there any existing file with inline asm diagnostics this can be added to?
There was a problem hiding this comment.
Used "-verify". I think the only one suitable file is clang/test/CodeGen/LoongArch/inline-asm-constraints-error.c, but it is target related.
clang/lib/CodeGen/CGStmt.cpp
Outdated
| if (Size) | ||
| Ty = llvm::IntegerType::get(getLLVMContext(), Size); | ||
| else | ||
| CGM.Error(S.getAsmLoc(), "Output operand is sizeless!"); |
There was a problem hiding this comment.
Can we use the SourceLocation of the specific operand in question, instead of using S.getAsmLoc(), which points at the beginning of the asm statement?
Diagnostics aren't capitalized, and don't end in punctuation.
Maybe say "size zero" instead of "sizeless".
There was a problem hiding this comment.
Replaced to OutExpr->getExprLoc() and change error message to output size should not be zero.
yetingk
changed the title
This fixes issue llvm#63878 caused by creating an integer with zero bitwidth.
|
Rebase and ping. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/2870 Here is the relevant piece of the build log for the reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #63878 caused by creating an integer with zero bitwidth.