Skip to content

Commit 6a38b29

Browse files
Disable non-conforming test (#135)
* Disable non-conforming test Replace it with our own similar test. The gfortran/regression/assign_5.f90 writes to a constant value which would cause that test to fail if constants are read-only. A replacement test assign-goto.f90 is introduced to check that this an assigned goto statement compiles and runs without issue. * Update Fortran/gfortran/regression/DisabledFiles.cmake Co-authored-by: Tom Eccles <[email protected]> --------- Co-authored-by: Tom Eccles <[email protected]>
1 parent 9144576 commit 6a38b29

File tree

5 files changed

+21
-0
lines changed

5 files changed

+21
-0
lines changed

Fortran/UnitTests/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# This file should only contain add_subdirectory(...) one for each test
22
add_subdirectory(hello)
3+
add_subdirectory(assign-goto)
34
add_subdirectory(fcvs21_f95) # NIST Fortran Compiler Validation Suite
45
add_subdirectory(finalization)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
llvm_singlesource()
2+
3+
file(COPY lit.local.cfg DESTINATION "${CMAKE_CURRENT_BINARY_DIR}")
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
subroutine s(x)
2+
integer :: x
3+
assign 222 to x
4+
goto x
5+
222 continue
6+
end subroutine s
7+
8+
program test
9+
integer :: a
10+
call s(a)
11+
end program test
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
config.traditional_output = True
2+
config.single_source = True

Fortran/gfortran/regression/DisabledFiles.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,6 +1534,10 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS
15341534
directive_unroll_5.f90
15351535
# Tests "!GCC$ attributes weak :: x"
15361536
weak-3.f90
1537+
# Test is not conformant as it writes to a constant argument
1538+
# Similar test, that is conformant, added to UnitTests/assign-goto
1539+
assign_5.f90
1540+
15371541

15381542
# Probable bugs
15391543
# ["a", "ab"]

0 commit comments

Comments
 (0)