Skip to content

Disable non-conforming test #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

Leporacanthicus
Copy link
Contributor

Replace it with our own similar test.

The gfortran/regression/assign_5.f90 writes to a constant value which would cause that test to fail if constants are read-only.

A replacement test assign-goto.f90 is introduced to check that this an assigned goto statement compiles and runs without issue.

Replace it with our own similar test.

The gfortran/regression/assign_5.f90 writes to a constant value
which would cause that test to fail if constants are read-only.

A replacement test assign-goto.f90 is introduced to check that
this an assigned goto statement compiles and runs without issue.
@Leporacanthicus
Copy link
Contributor Author

This replaces #134 that was "the wrong solution".

Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the correction to the comment that Tom has identified, LGTM. Tested on Linux on x86-64.

Thanks for the second PR, Mats.

@Leporacanthicus Leporacanthicus merged commit 6a38b29 into llvm:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants