Skip to content

[flang] Disable pr36006-2 on aarch64. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

vzakhari
Copy link
Contributor

@vzakhari vzakhari commented Mar 5, 2024

It used to fail due to the missing runtime support, but this
was not considered a failure.
It fails due to llvm/llvm-project#84088 now.

This should resolve the buildbot failure:
https://lab.llvm.org/buildbot/#/builders/184/builds/10735

It used to fail due to the missing runtime support, but this
was not considered a failure.
It fails due to llvm/llvm-project#84088 now.

This should resolve the buildbot failure:
https://lab.llvm.org/buildbot/#/builders/184/builds/10735
@vzakhari vzakhari merged commit 19e41d8 into llvm:main Mar 5, 2024
vzakhari added a commit to vzakhari/llvm-test-suite that referenced this pull request Mar 6, 2024
It used to fail due to the missing runtime support, but this
was not considered a failure.
It fails due to llvm/llvm-project#84088 now.

This should resolve the buildbot failure:
https://lab.llvm.org/buildbot/#/builders/184/builds/10735

This also reverts llvm#104.
vzakhari added a commit that referenced this pull request Mar 6, 2024
It used to fail due to the missing runtime support, but this
was not considered a failure.
It fails due to llvm/llvm-project#84088 now.

This should resolve the buildbot failure:
https://lab.llvm.org/buildbot/#/builders/184/builds/10735

This also reverts #104.
Copy link

@psteinfeld psteinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vzakhari
Copy link
Contributor Author

vzakhari commented Mar 6, 2024

Thank you, Pete! I am not sure what way of disabling the test I should use. It looks like this one did not work. I tried #105 and waiting for buildbots to pick it up.

@vzakhari
Copy link
Contributor Author

vzakhari commented Mar 6, 2024

It looks like #105 fixed the buildbots, so changes in tests.cmake does not seem to make any effect now. I also noticed that tests.cmake is auto-generated, so I should not have changed it in the first place :)

@tarunprabhu
Copy link
Contributor

so I should not have changed it in the first place :)

Yes :-) Thanks for #105

The tests.cmake files are intended to contain only the parsed DejaGNU annotations. Any additional "tweaks" - for instance to disable tests on certain platforms are intended to be done separately. I will add that feature next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants