Add a check before using -fno-define-target-os-macros
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshaoce
requested review from
zixu-w,
Bigcheese,
jroelofs,
ian-twilightcoder,
ributzka and
fhahn
jroelofs
reviewed
May 15, 2024
| # (https://github.com/madler/zlib/pull/895) | ||
| # Disable the compiler extension to workaround the build failure until a zlib | ||
| # source update with the fix. | ||
| target_compile_options(clamscan PRIVATE -fno-define-target-os-macros) |
There was a problem hiding this comment.
It would be better to use CheckCXXCompilerFlag, since there are versions of clang out there that don't support this flag.
https://cmake.org/cmake/help/latest/module/CheckCXXCompilerFlag.html
There was a problem hiding this comment.
Thank you for your suggestion! This is indeed a better solution.
jroelofs
approved these changes
May 15, 2024
sunshaoce
changed the title
-fno-define-target-os-macros for APPLE architecture-fno-define-target-os-macros
|
Many thanks @sunshaoce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error when testing on a board that supports RISC-V Vector 1.0:
cc: error: unrecogized command-line option '-fno-define-target-os-macros'I think the problem is probably caused by the lower version of cc?
But I think we can refer to this commit to solve it.
9b14a92
Add a condition that is only enabled on APPLE architecture for
-fno-define-target-os-macros.