Skip to content

[Fortran] Disable pr32601.f03 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[Fortran] Disable pr32601.f03 #156

merged 2 commits into from
Sep 5, 2024

Conversation

clementval
Copy link
Contributor

@clementval clementval commented Sep 5, 2024

llvm/llvm-project#107353 will relax the check when -pedantic is not enabled. -std=f2003 is not supported in flang. Disable the test until we have a way to add flags.

@tarunprabhu
Copy link
Contributor

We don't allow changes to the actual tests in this suite. Trying to find a way to add/remove flags so such tests can be run is on my list of things to do.

For now, there are two options:

  1. Disable this test. You can add it to the FAILING section of Fortran/gfortran/regression/DisabledFiles.cmake with a comment indicating why it has been disabled.

  2. Disable this test and add a similar one to Fortran/UnitTests. There are a couple of examples of this such as Fortran/UnitTests/assign-goto.

Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment on what needs to be changed. Thanks.

@clementval
Copy link
Contributor Author

clementval commented Sep 5, 2024

See my previous comment on what needs to be changed. Thanks.

Thank you. I was not aware that we want to keep the original test as is. I'll update this patch.

@clementval clementval changed the title [Fortran] Add -pedantic to pr32601.f03 [Fortran] Disable pr32601.f03 Sep 5, 2024
Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change, Valentin. :-)

@clementval clementval merged commit d6a91b8 into main Sep 5, 2024
1 check passed
@clementval clementval deleted the clementval-patch-1 branch September 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants