[SPEC] Define arch/os portability flag for riscv64-linux-gnu #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without -DSPEC_MANUAL_CONFIG (or another dummy arch/os flag specified), 500.perlbench_r will fail to build on riscv64-linux-gnu. -DSPEC_LP64 and -DSPEC_LINUX are also already defined via the generic handlers above. I'm not sure if we need to define more flags, but this enough to get things building.
asb
approved these changes
Oct 24, 2024
SixWeining
added a commit
that referenced
this pull request
Nov 27, 2024
Similar to #158. Without this change, 500.perlbench_r will fail to build on LoongArch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without -DSPEC_MANUAL_CONFIG (or another dummy arch/os flag specified), 500.perlbench_r will fail to build on riscv64-linux-gnu. -DSPEC_LP64 and -DSPEC_LINUX are also already defined via the generic handlers above. I'm not sure if we need to define more flags, but this enough to get things building.