[Fortran/gfortran] Disable bounds-check tests. #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests started failing at -O2 after llvm/llvm-project#121544 Flang inlines hlfir.assign with hlfir.expr RHSs after the change, so the runtime is not called, and it does not make the bounds checks. Related feature request: https://github.com/orgs/llvm/projects/12?pane=issue&itemId=29048733
tarunprabhu
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Will these tests ever pass in the future? In other words, as far as these tests are concerned, will flang's behavior always be different from gfortran? If so, could you add a comment clarifying this. It will help sort out which tests we can permanently disable.
|
Thank you for the review! These tests will pass with |
Got it! I'm glad that that comment is still relevant. Thanks for the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests started failing at -O2 after llvm/llvm-project#121544
Flang inlines hlfir.assign with hlfir.expr RHSs after the change,
so the runtime is not called, and it does not make the bounds checks.
Related feature request: Flang features to be implemented