Skip to content

[Fortran/gfortran] Disable bounds-check tests for matmul tests. #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vzakhari
Copy link
Contributor

The tests started failing at -O2 after llvm/llvm-project#122821
Flang inlines hlfir.matmul[_transpose] after the change,
so the runtime is not called, and it does not make the bounds checks.
Related feature request: Flang features to be implemented

The tests started failing at -O2 after llvm/llvm-project#122821
Flang inlines hlfir.matmul[_transpose] after the change,
so the runtime is not called, and it does not make the bounds checks.
Related feature request: https://github.com/orgs/llvm/projects/12?pane=issue&itemId=29048733
@vzakhari vzakhari requested a review from tarunprabhu January 15, 2025 18:22
Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@vzakhari vzakhari merged commit 1f917f9 into llvm:main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants