-
Notifications
You must be signed in to change notification settings - Fork 349
[HIP] Add cuda_wrapper tests from Externals/CUDA using hipify-perl #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
1849bc4
to
4c88c3e
Compare
4c88c3e
to
2f699f4
Compare
2f699f4
to
4abe1ec
Compare
@jplehr do you have some advice about how I can ensure that this change doesn't break any of our buildbots ? I've run the test locally and it works. I still have to ensure that |
I believe we currently do not install this as part of the CI images, so we need to update the container images that we run. Let me check and get back to you. |
4abe1ec
to
57ae476
Compare
@jplehr I double checked and this PR is already not failing if hipify-perl is not found. It shows:
If there are no extra remarks we could:
Maybe on Tuesday, cause I don't want to break everything before a 3 day weekend. What do you all think ? |
Our bots should pick up changes to llvm-test-suite whenever we run a build of LLVM. Whatever works better for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll give it a go today then. I'll watch the bots: staging bot -> It worked ! https://lab.llvm.org/staging/#/builders/93/builds/6480 |
This PR tries to adapt in a pretty rough way some tests from
Externals/CUDA
that test interactions withcuda_wrapper
headers.This catch the bug fixed by llvm/llvm-project#139697