[External][Smoke] Adding the aomp smoke suite to externals #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplehr
reviewed
Oct 11, 2023
There was a problem hiding this comment.
I have left an initial comment about tests that for sure depend on downstream functionality. There may be more for which this is true.
Also, as mentioned in Slack, you probably want to pin the version you actually pulling, as we may move tests from smoke into smoke-limbo or smoke-fails.
A general question: Do you intend to use the check_smoke.sh script run them?
fel-cab
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting the tests from ROCm-Developer-Tools to the External folder. For further testing of OpenMP Clang in LLVM.