[CLAMR] remove unused codes #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jerryzj
commented
Oct 31, 2023
jerryzj
commented
- The variable "progCL" is a l-value and never get used, but it will cause SEGV when argv (binary file path) is longer than its pre-defined length.
- The variable "progCL" is a l-value and never get used, but it will cause SEGV when argv (binary file path) is longer than its pre-defined length. Signed-off-by: Jerry Zhang Jian <[email protected]>
|
I can't remember why we created that but I think it's left-over from the time we had to handle with non-reproducible builds. If this still passes the test-suite on all platforms and isn't used, then it's fine to remove. |
rengolin
approved these changes
Oct 31, 2023
|
Yes, we can verify that these codes will be removed by the compiler when we enable optimizations. We encountered a SEGV only in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.