[Fortran/gfortran] Add a simple not tool to the test suite #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunprabhu
requested review from
tblah,
kiranchandramohan,
cabreraam,
jeanPerier and
vzakhari
|
Thanks for working on this! I'll have a look next week. |
tblah
reviewed
Dec 11, 2023
yiwu0b11
reviewed
Dec 12, 2023
yiwu0b11
reviewed
Dec 12, 2023
cabreraam
reviewed
Dec 12, 2023
cabreraam
approved these changes
Dec 13, 2023
yiwu0b11
approved these changes
Dec 13, 2023
Add a tool similar to LLVM's not utility which inverts the return code of a command. The major difference is that the utility is not dependent on LLVM's libraries and performs less error checking than LLVM's not. It supports the --crash option when the command is expected to crash. The tests in Fortran/gfortran have been updated to use this.
tarunprabhu
force-pushed
the
import-llvm-not
branch
from
75e700a to
51262d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tool very similar to LLVM's not utility which inverts the return code of a command. The major difference is that the utility is not dependent on LLVM's libraries and performs less error checking than LLVM's not. It does support the
--crash option when the command is expected to crash.
There is a need for something similar to the
notutility in the gfortran test suite where some tests are expected to crash. However, we cannot rely on the utility being available since the LLVM build directory may not be available when running the test suite. Unless LLVM was built with-DLLVM_INSTALL_UTILS=On, the utilities will not be available even if clang/flang are present.In keeping with some of the other tools in the test suite which were borrowed from LLVM, this has been stripped down and made independent of LLVM's libraries.