Skip to content

[flang] Enable tests that have structure constructors with allocatable component #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kkwli
Copy link
Contributor

@kkwli kkwli commented Jan 18, 2024

No description provided.

Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, the list looks good to me and the test-suite passed for me.

Copy link
Contributor

@tarunprabhu tarunprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update.

@kkwli
Copy link
Contributor Author

kkwli commented Jan 18, 2024

Thanks for the review.

@kkwli kkwli merged commit f377b27 into llvm:main Jan 18, 2024
@kkwli kkwli deleted the ctor-test branch January 18, 2024 18:04
@DavidSpickett
Copy link
Contributor

I had to disable 1 of these 44df7fa.

Maybe @luporl will know what the proper fix there is?

@luporl
Copy link
Contributor

luporl commented Jan 19, 2024

I would actually be surprised if this test (pr43808) passes on other architectures.

IIUC, both -fstrict-aliasing and -fschedule-insns flags are not supported by flang:
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L3687
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L6177

@luporl
Copy link
Contributor

luporl commented Jan 19, 2024

#77 fixes the issue and re-enables pr43808 test.

@kkwli
Copy link
Contributor Author

kkwli commented Jan 19, 2024

Thanks @DavidSpickett and @luporl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants