[Fortran] mark rhs LEN parameter tests as implemented #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char_length_2{0,1}.f90 were fixed in
llvm/llvm-project#80412.
Now that these successfully compile I thought I might as well
re-categorise the other tests in the same group too.
tblah
force-pushed
the
ecclescake/char_length
branch
from
c6dd6f4 to
b281a2e
Compare
tarunprabhu
reviewed
Feb 2, 2024
| elemental_function_3.f90 | ||
| elemental_function_2.f90 | ||
| realloc_on_assign_14.f90 | ||
| widechar_11.f90 |
There was a problem hiding this comment.
widechar_11.f90 fails to compile for me on Linux x86_64.
Fortran/gfortran/regression/widechar_11.f90:14:1: error: No intrinsic or user-defined ASSIGNMENT(=) matches operand types TYPE(c_ptr) and TYPE(__builtin_c_ptr)
cptr = c_loc(a4str)
^^^^^^^^^^^^^^^^^^^
Fortran/gfortran/regression/widechar_11.f90:14:14: warning: C_LOC() argument has non-interoperable intrinsic type, kind, or length
cptr = c_loc(a4str)
^^^^^
Fortran/gfortran/regression/widechar_11.f90:15:1: error: No intrinsic or user-defined ASSIGNMENT(=) matches operand types TYPE(c_ptr) and TYPE(__builtin_c_ptr)
cptr2 = c_loc(a4str2)
^^^^^^^^^^^^^^^^^^^^^
Fortran/gfortran/regression/widechar_11.f90:15:15: warning: C_LOC() argument has non-interoperable intrinsic type, kind, or length
cptr2 = c_loc(a4str2)
^^^^^^
Fortran/gfortran/regression/widechar_11.f90:31:11: error: No specific function of generic 'c_associated' matches the actual arguments
if (.not. c_associated (cptr, c_loc(a4str))) error stop
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fortran/gfortran/regression/widechar_11.f90:31:37: warning: C_LOC() argument has non-interoperable intrinsic type, kind, or length
if (.not. c_associated (cptr, c_loc(a4str))) error stop
^^^^^
Fortran/gfortran/regression/widechar_11.f90:32:11: error: No specific function of generic 'c_associated' matches the actual arguments
if (.not. c_associated (cptr2, c_loc(a4str2))) error stop
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fortran/gfortran/regression/widechar_11.f90:32:38: warning: C_LOC() argument has non-interoperable intrinsic type, kind, or length
if (.not. c_associated (cptr2, c_loc(a4str2))) error stop
^^^^^^
Perhaps the configuration parameters are different?
There was a problem hiding this comment.
Thanks for checking this. I couldn't reproduce this with or without optimization flags so I guess it really is something to do with definitions of C pointers on different platforms. Strange.
|
I can't test this today. I will do so tomorrow. Apologies for the delay. |
tarunprabhu
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
char_length_2{0,1}.f90 were fixed in
llvm/llvm-project#80412.
Now that these successfully compile I thought I might as well re-categorise the other tests in the same group too.