[AArch64][FMV] Enable tests for ACLE FMV on Linux. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling Linux part of llvm#87
jroelofs
reviewed
Feb 21, 2024
| # TODO: this test is currently only supported on Darwin platforms: | ||
| if (TARGET_OS MATCHES "Darwin") | ||
| list(APPEND Source acle-fmv-features.c) | ||
| endif() |
There was a problem hiding this comment.
Does it get added to Sources automatically for all platforms now?
There was a problem hiding this comment.
I think so looking into
But I tested that on aarch64/x86 Linux only
There was a problem hiding this comment.
ok, seems fine. If we have trouble with non-posix systems (Fuchsia? Windows?) I guess those can be opted out if the buildbots complain.
Co-authored-by: Jon Roelofs <[email protected]>
jroelofs
approved these changes
Feb 23, 2024
|
One of these is failing on our bot: https://lab.llvm.org/buildbot/#/builders/183/builds/19626 It's hard to find the failures in these test suite dumps, so far I only see: I'll see if I can find the reason for that. |
ilinpv
added a commit
to ilinpv/llvm-test-suite
that referenced
this pull request
Feb 23, 2024
The patch fixes buildbot failures discovered in llvm#98 by checking for compiler-rt availability. Existence of compiler-rt builtin check was added to find_compiler_rt_library function.
ilinpv
added a commit
that referenced
this pull request
Feb 25, 2024
The patch fixes buildbot failures discovered in #98 by checking for compiler-rt availability. Existence of compiler-rt builtin check was added to find_compiler_rt_library function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling Linux part of #87