[TORCH] Add support for logcumsumexp Op #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharavana20
force-pushed
the
logcumsumexp
branch
4 times, most recently
from
cdba452 to
6a20e5e
Compare
|
Hi @vivekkhandelwal1 @penguin-wwy @AmosLewis @zjgarvey — I’d be grateful if any of you could take a look at this PR. Your feedback would be greatly appreciated! |
Signed-off-by: sharavana20 <[email protected]>
vivekkhandelwal1
requested review from
vivekkhandelwal1,
zjgarvey,
praveen-g-ctt and
AmosLewis
vivekkhandelwal1
requested changes
May 27, 2025
projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/torch_ods_gen.py
Outdated
Show resolved
Hide resolved
|
@vivekkhandelwal1 Thanks a lot for the feedback. I’ve updated the code based on your comments. |
Signed-off-by: sharavana20 <[email protected]>
|
Thanks for the review, @vivekkhandelwal1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logcumsumexp(x) = log(cumsum(exp(x)))
This implementation addresses and closes #4183