Skip to content

[TorchToLinalg] Enable lowering of AtenMaxPool1dWithIndicesOp to linalg dialect #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zahidwx
Copy link
Contributor

@zahidwx zahidwx commented May 30, 2025

This PR takes care of #4214.

  • Enable lowering of AtenMaxPool1dWithIndicesOp to linalg backend
  • Add missing shape & dtype inference in abstract library (fixes Torchscript IR --> Torch IR conversion)
  • Update xfail sets
  • Add support for ceil_mode in torch to stablehlo lowering of AtenMaxPool1dWithIndicesOp

@zahidwx zahidwx force-pushed the feature/Maxpool1dIndices branch from 8f7c53a to d6c3a9b Compare May 30, 2025 20:41
@zahidwx zahidwx marked this pull request as ready for review May 30, 2025 22:04
@zahidwx zahidwx changed the title Enable lowering of AtenMaxPool1dWithIndicesOp to linalg dialect [TorchToLinalg] Enable lowering of AtenMaxPool1dWithIndicesOp to linalg dialect May 30, 2025
@zahidwx zahidwx force-pushed the feature/Maxpool1dIndices branch from d592fda to 57d14be Compare June 1, 2025 06:48
@zahidwx
Copy link
Contributor Author

zahidwx commented Jun 2, 2025

@stellaraccident | @vivekkhandelwal1 | @zjgarvey Can I get a review on this please?

@vivekkhandelwal1 vivekkhandelwal1 self-requested a review June 9, 2025 14:50
@zahidwx zahidwx force-pushed the feature/Maxpool1dIndices branch from 57d14be to 600c584 Compare June 11, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant