-
Notifications
You must be signed in to change notification settings - Fork 240
ci: switch Travis to Github Actions #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have limited knowledge on GitHub Actions, but it LGTM. Please see my minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @agnes512! I have one comment to address, PTAL 👇🏻
Considering that our CI is broken right now, I think it's ok to land this change as-is even if it's breaking code coverage, and then restore Coveralls integration in a follow-up pull request.
services: | ||
- mongodb | ||
|
||
after_success: npm run coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this command is publishing code coverage data to https://coveralls.io/github/strongloop/loopback-connector-mongodb. Can you please preserve this step in the new GHA workflow too?
I think it should be enough to add a new step at the end of the file:
- run: npm install
- run: npm test
env:
CI: true
- run: npm run coverage
28c9299
to
0a6934f
Compare
I was investigating adding coveralls to the workflow ( |
eaff882
to
1f2297d
Compare
@bajtos I tried to enable coveralls like https://coveralls.io/builds/32304908. But I don't know how to do it like Travis does. Seems like Travis has some repo token that coveralls.io would use. Not sure how this can be done with Also, seems like the and it has Not sure if it's possible to have pages like coveralls.io for our case. Would you want me to invest more? I also noticed that when we changed from Travis to Github action, we dropped the coveralls report for loopback-next. loopbackio/loopback-next#5110 Again, not sure how complicated it would be. But we might want to have the report for loopback-next. Please let me know if you have any concerns. Thanks. |
Signed-off-by: Agnes Lin <[email protected]>
Notice that we were using mongodb 3.2 for Travis. That version runs into connection errors in GitHub action. This PR uses the latest stable version of mongodb (4.4) for Github action.
Checklist
npm test
passes on your machine