Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Bump Scala 3.0.0-M1/Remove workaround/Correct extensions syntax #70

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

eloots
Copy link
Contributor

@eloots eloots commented Nov 9, 2020

@eloots eloots requested review from njlbenn and robinraju November 9, 2020 07:16
…ions syntax

- Dotty 0.27.0-RC1 broke logging calls due to [Ambiguous overload between varargs and non-varargs #9688](scala/scala3#9688)
  which was fixed in [Fix vararg overloading #9732](scala/scala3#9732)
- Remove a few remaining extension methods that still used an 'older' extension
  mothod syntax
@eloots eloots force-pushed the bump-dotty-to-scala-3.0.0-M1 branch from 5fd315a to b729147 Compare November 9, 2020 07:17
Copy link
Contributor

@robinraju robinraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@robinraju robinraju linked an issue Nov 9, 2020 that may be closed by this pull request
- Exercise on extentions still used a syntax that has since then
  been changed
- Use indentation based syntax in instructions
@eloots eloots merged commit 215ad70 into main Nov 9, 2020
@eloots eloots deleted the bump-dotty-to-scala-3.0.0-M1 branch November 9, 2020 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workaround for ambiguous between varargs and non-varargs
2 participants