Skip to content

$myvar{'innodb_stats_on_metadata'} may not exist #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2019
Merged

$myvar{'innodb_stats_on_metadata'} may not exist #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a1b60
Fix error when `innodb_stats_on_metadata` not defined
May 15, 2019
b10c90c
Fix typo on `myvar`
May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions mysqltuner.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5766,14 +5766,16 @@ sub mysql_innodb {

sub check_metadata_perf {
subheaderprint "Analysis Performance Metrics";
infoprint "innodb_stats_on_metadata: " . $myvar{'innodb_stats_on_metadata'};
if ( $myvar{'innodb_stats_on_metadata'} eq 'ON' ) {
badprint "Stat are updated during querying INFORMATION_SCHEMA.";
push @adjvars, "SET innodb_stats_on_metadata = OFF";

#Disabling innodb_stats_on_metadata
select_one("SET GLOBAL innodb_stats_on_metadata = OFF;");
return 1;
if (defined $myvar{'innodb_stats_on_metadata'}) {
infoprint "innodb_stats_on_metadata: " . $myvar{'innodb_stats_on_metadata'};
if ( $myvar{'innodb_stats_on_metadata'} eq 'ON' ) {
badprint "Stat are updated during querying INFORMATION_SCHEMA.";
push @adjvars, "SET innodb_stats_on_metadata = OFF";

#Disabling innodb_stats_on_metadata
select_one("SET GLOBAL innodb_stats_on_metadata = OFF;");
return 1;
}
}
goodprint "No stat updates during querying INFORMATION_SCHEMA.";
return 0;
Expand Down