Skip to content

correct messages on no InnoDB #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021
Merged

correct messages on no InnoDB #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions mysqltuner.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5557,21 +5557,28 @@ sub mysql_innodb {

# InnoDB
unless ( defined $myvar{'have_innodb'}
&& $myvar{'have_innodb'} eq "YES"
&& defined $enginestats{'InnoDB'} )
&& $myvar{'have_innodb'} eq "YES")
{
if ( $opt{skipsize} eq 1 ) {
infoprint "Skipped due to --skipsize option";
return;
}
infoprint "InnoDB is disabled.";
if ( mysql_version_ge( 5, 5 ) ) {
my $defengine = 'InnoDB';
$defengine = $myvar{'default_storage_engine'} if defined($myvar{'default_storage_engine'});
badprint
"InnoDB Storage engine is disabled. InnoDB is the default storage engine";
"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine eq 'InnoDB';
infoprint
"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine ne 'InnoDB';
}
return;
}
infoprint "InnoDB is enabled.";
if (! defined $enginestats{'InnoDB'} ) {
if ( $opt{skipsize} eq 1 ) {
infoprint "Skipped due to --skipsize option";
return;
}
badprint "No tables are Innodb";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cosmetic s/Innodb/InnoDB/

$enginestats{'InnoDB'} = 0;
}

if ( $opt{buffers} ne 0 ) {
infoprint "InnoDB Buffers";
Expand Down