Some tweaks and fixes #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Projects which use scalatest-embedded-kafka may have their own slf4j bindings which can conflict with these
| lazy val commonSettings = Seq( | ||
| name := "scalatest-embedded-kafka", | ||
| organization := "net.manub", | ||
| crossScalaVersions := Seq("2.10.6", "2.11.7"), |
There was a problem hiding this comment.
I still have clients that use 2.10. Would that cause an issue?
There was a problem hiding this comment.
That was a local change that wasn't supposed to get committed, fixing.
|
Thanks @kciesielski - LGTM. Will merge and release ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes were implemented when I was trying to make
scalatest-embedded-kafkawork with reactive kafkaWith these changes your library seems to work well with Reactive Kafka 0.11 :)