Add batch consumption of messages #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manub
reviewed
Jan 29, 2017
| implicit config: EmbeddedKafkaConfig, | ||
| deserializer: Deserializer[T]): List[T] = { | ||
|
|
||
| import scala.collection.JavaConversions._ |
There was a problem hiding this comment.
JavaConversions is deprecated in 2.12. Could you please use JavaConverters instead?
nguyenuy
force-pushed
the
add_batch_consumption
branch
from
0d4347f to
d4864ef
Compare
|
@manub added import scala.collection.JavaConverters._ within that specific function. Didn't want to do too much changing elsewhere |
|
Is there anything else you need for this PR? |
|
Sorry I didn't have time to carry on reviewing! LGTM, will merge. |
|
I will release a new patch version shortly. |
|
Released in v0.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #66 with this commit. Also added appropriate test coverage. Please take a look