Make EmbeddedKafkaConfig a trait to allow other implementation

[max5599]

I'm using Kafka and a schema registry to serialize messages.
I've made a trait that allow me to run a Kafka and a schema registry:

trait EmbeddedKafkaAndSchemaRegistrySupport extends EmbeddedKafka {
  this: Suite =>

  def withRunningKafkaAndSchemaRegistry[T](block: (ConfluentConfig) => T): T = {
    implicit val kafkaConfig: EmbeddedKafkaConfig = new EmbeddedKafkaConfig(zooKeeperPort = getEphemeralPort, kafkaPort = getEphemeralPort)
    EmbeddedKafka.start()
    try {
      val confluentConfig = ConfluentConfig(kafkaConfig, schemaRegistryPort = getEphemeralPort)
      val schemaRegistry = startSchemaRegistry(confluentConfig)
      try {
        block(confluentConfig)
      } finally {
        schemaRegistry.stop()
      }
    } finally {
      EmbeddedKafka.stop()
    }
  }
}

case class ConfluentConfig(embeddedKafkaConfig: EmbeddedKafkaConfig, schemaRegistryPort : Int)

ConfluentConfig can't extend EmbeddedKafkaConfig because it's a case class so when using 'withRunningKafkaAndSchemaRegistry' I have to declare the implicit EmbeddedKafkaConfig:

withRunningKafkaAndSchemaRegistryAndImpressionEventSerializer { implicit config => implicit serializer =>
      implicit val kafkaConfig: EmbeddedKafkaConfig = config.embeddedKafkaConfig
      publishToKafka("topic", impressionEvent)
      ...
}

I'd like to make EmbeddedKafkaConfig a trait then make ConfluentConfig implements it to avoid declaring each time the EmbeddedKafkaConfig.
Does it make sense? Maybe there's another solution?
I've tried with implicit conversion but without success.
If that make sense I'll make the modifications then a pull request.

[manub]

Is ConfluentConfig a class provided by Confluent? If that's the case you could overload that method and have another version that works with ConfluentConfig.

[max5599]

ConfluentConfig is a class I made that wrap EmbeddedKafkaConfig and the schema registry port.
So if a trait exists, I can extend it.
PS: sorry for the late answer

[manub]

That's ok - feel free to submit a PR for this!

[manub]

those should all be defs. https://stackoverflow.com/questions/19642053/when-to-use-val-or-def-in-scala-traits