config: Fix ngx_module_type

[Whissi]

Since commit 37182ce the module was always build as dynamic module.
Probably because following a bad skeleton [1].

With this change we will only build a dynamic module when requested. Otherwise
we will fall back to static build.

Link: https://trac.nginx.org/nginx/ticket/1115
Gentoo-Bug: https://bugs.gentoo.org/593450
Fixes: #50

[Whissi]

Please wait for upstream response in ticket https://trac.nginx.org/nginx/ticket/1115 before merging.

[masterzen]

@Whissi can you ping me in this PR or the original bug when we get a definitive answer in the Nginx ticket?

[Whissi]

Yep.

[Whissi]

OK, I was wrong. Nginx upstream closed my ticket as invalid. The problem wasn't that the check was invalid (the check was correct; the only purpose of the check was to determine if the "new" build system/script can be used or not), the problem was that an invalid ngx_module_type was set.

auto/module runs

    eval ${ngx_module_type}_MODULES=\"\$${ngx_module_type}_MODULES \
                                      $ngx_module_name\"

so the set value FILTER caused the module to be registered in the FILTER_MODULES variable.

However that's an unsupported type (see https://www.nginx.com/resources/wiki/extending/new_config/#key-ngx_module_type for supported types), i.e. the auto/modules script only honors

    modules="$modules $HTTP_MODULES $HTTP_FILTER_MODULES \
             $HTTP_AUX_FILTER_MODULES $HTTP_INIT_FILTER_MODULES"

with the result that the module was never recorded in objs/ngx_modules.c (however the module was built at all because the source files were added to NGX_ADDON_SRCS).

The first proposed patch worked because it ensured that the old code was used which used the correct module type (see

nginx-upload-progress-module/config

Line 9 in ee8d5dd

HTTP_FILTER_MODULES="$HTTP_FILTER_MODULES ngx_http_uploadprogress_module"

).

I updated the PR; This can now be finally merged :)

[masterzen]

@Whissi many thanks for the explanations and this PR!
Merging.

[pgaertig]

@masterzen thanks for the merge, would it be fine to release 0.9.3? I try to avoid dependency on live master branch in my nginx build script.