Skip to content

Extra table components #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

Extra table components #125

merged 2 commits into from
Aug 5, 2019

Conversation

michaelrevans
Copy link
Collaborator

Issue #92: Add thead, tbody and tfoot components

Changes

  • thead, tbody and tfoot components
  • tests all inside of table_spec.rb
  • docs added to table.md doc

Notes

  • It made sense to add these together, as they are quite closely related.

@michaelrevans
Copy link
Collaborator Author

replaces #119

pascalwengerter
pascalwengerter approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @michaelrevans!

@pascalwengerter pascalwengerter merged commit 865de56 into develop Aug 5, 2019
@pascalwengerter pascalwengerter deleted the extra-table-components branch August 5, 2019 19:53
@pascalwengerter pascalwengerter mentioned this pull request Aug 5, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.2 milestone Sep 5, 2019
@jonasjabari jonasjabari mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelrevans @pascalwengerter @jonasjabari