-
-
Notifications
You must be signed in to change notification settings - Fork 43
Add article component with docs and specs #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
%article{@tag_attributes} | ||
- if options[:text].nil? && block_given? | ||
= yield | ||
- else | ||
= options[:text] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
module Matestack::Ui::Core::Article | ||
class Article < Matestack::Ui::Core::Component::Static | ||
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# matestack core component: Blockquote | ||
|
||
Show [specs](../../spec/usage/components/article_spec.rb) | ||
|
||
The HTML article tag implemented in ruby. | ||
|
||
## Parameters | ||
|
||
This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param. | ||
|
||
#### # id (optional) | ||
Expects a string with all ids the span should have. | ||
|
||
#### # class (optional) | ||
Expects a string with all classes the span should have. | ||
|
||
#### # text - optional | ||
Expects a string which will be displayed as the content inside the `article`. If this is not passed, a block must be passed instead. | ||
|
||
## Example 1: Yield a given block | ||
|
||
```ruby | ||
article do | ||
paragraph text: "Hello world" | ||
end | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<article> | ||
<p>Hello world</p> | ||
</article> | ||
``` | ||
|
||
## Example 2: Render options[:text] param | ||
|
||
```ruby | ||
article text: "Hello world" | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<article>Hello world</article> | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
require_relative "../../support/utils" | ||
include Utils | ||
|
||
describe 'Article Component', type: :feature, js: true do | ||
|
||
it 'Example 1 - yield, no options[:text]' do | ||
|
||
class ExamplePage < Matestack::Ui::Page | ||
|
||
def response | ||
components { | ||
article do | ||
paragraph text: "Hello world" | ||
end | ||
} | ||
end | ||
|
||
end | ||
|
||
visit '/example' | ||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<article><p>Hello world</p></article> | ||
HTML | ||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
end | ||
|
||
it 'Example 2 - render options[:text]' do | ||
|
||
class ExamplePage < Matestack::Ui::Page | ||
|
||
def response | ||
components { | ||
article text: "Hello world" | ||
} | ||
end | ||
|
||
end | ||
|
||
visit '/example' | ||
|
||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<article>Hello world</article> | ||
HTML | ||
|
||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.