Skip to content

add sub tag #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
matestack-ui-core (0.7.0)
matestack-ui-core (0.7.1)
cells-haml
cells-rails
haml
Expand Down
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/sub/sub.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
%sub{@tag_attributes}
- if options[:text].nil? && block_given?
= yield
- else
= options[:text]
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/sub/sub.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module Matestack::Ui::Core::Sub
class Sub < Matestack::Ui::Core::Component::Static

end
end
47 changes: 47 additions & 0 deletions docs/components/sub.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# matestack core component: Sub

Show [specs](../../spec/usage/components/sub_spec.rb)

The HTML sub tag implemented in ruby.

## Parameters

This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.

#### # id (optional)
Expects a string with all ids the sub should have.

#### # class (optional)
Expects a string with all classes the sub should have.

#### # text (optional)
Expects a string with the text that should go into the `<sub>` tag.

## Example 1: Yield a given block

```ruby
sub id: "foo", class: "bar" do
plain 'Hello World' # optional content
end
```

returns

```html
<sub id="foo" class="bar">
Hello World
</sub>
```

## Example 2: Render options[:text] param

```ruby
sub id: "foo", class: "bar", text: 'Hello World'
```

returns

```html
<sub id="foo" class="bar">
Hello World
</sub>
66 changes: 66 additions & 0 deletions spec/usage/components/sub_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
require_relative "../../support/utils"
include Utils

describe 'Sub Component', type: :feature, js: true do

it 'Example 1 - yield, no options[:text]' do

class ExamplePage < Matestack::Ui::Page

def response
components {
# simple sub
sub do
plain 'I am simple'
end

# enhanced sub
sub id: 'my-id', class: 'my-class' do
plain 'I am enhanced'
end
}
end

end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<sub>I am simple</sub>
<sub id="my-id" class="my-class">I am enhanced</sub>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end

it 'Example 2 - render options[:text]' do

class ExamplePage < Matestack::Ui::Page

def response
components {
# simple sub
sub text: 'I am simple'

# enhanced sub
sub id: 'my-id', class: 'my-class',text: 'I am enhanced'
}
end

end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<sub>I am simple</sub>
<sub id="my-id" class="my-class">I am enhanced</sub>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end

end