Skip to content

Add class option to dropdown form selects #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

Add class option to dropdown form selects #135

merged 1 commit into from
Aug 15, 2019

Conversation

3wille
Copy link
Contributor

@3wille 3wille commented Aug 13, 2019 •
edited
Loading

Until now it was not possible to add a class to the <select> field.
This fixes the behaviour of the form_select type: :dropdown to be
more similar to other components.

@3wille
Add class option to dropdown form selects
0ff7668 
Until now it was not possible to add a class to the ``<select>`` field.
This fixes the behaviour of the ``form_select type: :dropdown`` to be
more similar to other components.
@3wille 3wille force-pushed the fw-fix-class-on-form-select branch from 967903b to 0ff7668 Compare August 13, 2019 14:07
@pascalwengerter
Copy link
Contributor

Hey @3wille this looks good to me, well done! Could you change the PR target to develop? The master branch always represents the last release

@pascalwengerter pascalwengerter added the enhancement New feature or request label Aug 15, 2019
@pascalwengerter pascalwengerter self-requested a review August 15, 2019 07:06
@3wille 3wille changed the base branch from master to develop August 15, 2019 09:43
@3wille
Copy link
Contributor Author

3wille commented Aug 15, 2019

Hey @pascalwengerter thanks. I changed the base branch of this PR.
I'd also like to add that imo all core components should support the attributes parameter, which is currently not the case. Shall I open an issue for that?

@jonasjabari
Copy link
Member

Hey @3wille. Welcome on board! Thanks for your PR! Do you want to join our gitter chat? We also have weekly matestack calls. I would love to see/hear you there!

@jonasjabari jonasjabari merged commit 6f42c9e into matestack:develop Aug 15, 2019
@jonasjabari
Copy link
Member

And yes, please create an issue for the missing attributes param support, @3wille :)

@3wille 3wille deleted the fw-fix-class-on-form-select branch August 15, 2019 12:35
@3wille
Copy link
Contributor Author

3wille commented Aug 15, 2019

For reference, the new issue: #136

@jonasjabari

Do you want to join our gitter chat?

Sure, feel free to add me, but I won't have much time for this nor will I be able to join the calls. My Email Address should be publicly visible at my github profile

@jonasjabari jonasjabari added this to the 0.7.2 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjabari jonasjabari jonasjabari approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@3wille @pascalwengerter @jonasjabari