Add <s> tag to core components #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.7.2.1 Release (Urgent Image Component Bug Fix Release)
pascalwengerter
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
Great work overall, thank you @Manukam! Minor formatting and then we're good to merge!
Care to join our Gitter channel if you would like to stay in touch with matestack? https://gitter.im/basemate/community
| module Matestack::Ui::Core::S | ||
| class S < Matestack::Ui::Core::Component::Static | ||
|
|
||
| end |
There was a problem hiding this comment.
Formatting, please! (being picky, sorry)
pascalwengerter
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #170 - Add s tag to core components
Changes
Created s folder, s.haml and s.rb files to matestack ui core components
Created s.md to docs > components
Created s_spec.rb to usage > components
Notes