Skip to content

Add dd component. #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Add dd component. #217

merged 1 commit into from
Oct 4, 2019

Conversation

mayanktap
Copy link
Contributor

Issue #182: Addition of Dd Component.

Changes

  • Add dd component.
  • Add dd documentation.
  • Add dd spec.

@pascalwengerter pascalwengerter self-requested a review October 4, 2019 12:02
pascalwengerter
pascalwengerter approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @mayanktap! Would you like to take care of #186 next so both <dd> and <dt> can be used inside their <dl> parent component? 💪

@pascalwengerter pascalwengerter merged commit 824a576 into matestack:develop Oct 4, 2019
@pascalwengerter pascalwengerter mentioned this pull request Oct 4, 2019
Closed
@mayanktap
Copy link
Contributor Author

Sure @pascalwengerter . I was thinking the same to pick issue #186.

@jonasjabari jonasjabari added this to the 0.7.3 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mayanktap @pascalwengerter @jonasjabari