Skip to content

ISSUE #123 adds aside component to main components #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

cameronnorman
Copy link
Collaborator

Issue #123: Aside Component

Changes

  • Adds the Aside component

Notes

  • Nothing special

@cameronnorman cameronnorman changed the title Issue 123 ISSUE #123 adds aside component to main components Oct 4, 2019
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some typos and we're good to merge!

This component can take 2 optional configuration params and optional content.

#### # id (optional)
Expects a string with all ids the p should have.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, this isn't the <p> tag

Expects a string with all ids the p should have.

#### # class (optional)
Expects a string with all classes the p should have.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, this isn't the <p> tag

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pascalwengerter pascalwengerter merged commit 340d6ae into develop Oct 9, 2019
@pascalwengerter pascalwengerter deleted the issue-123 branch October 9, 2019 13:59
@jonasjabari jonasjabari added this to the 0.7.3 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants