ISSUE #183 Adds del component #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
suggested changes
Oct 7, 2019
There was a problem hiding this comment.
Hey @cameronnorman, great work but I'm missing the cite and datetime params from the HTML API, details see here: https://www.w3schools.com/tags/tag_del.asp
Could you add them?
|
@cameronnorman I think if you merge the latest version of the |
michaelrevans
previously approved these changes
Nov 7, 2019
cameronnorman
force-pushed
the
issue-183
branch
from
bd74b79 to
895094f
Compare
|
Hey @pascalwengerter @michaelrevans please can I get a review on this one now that the branch is up to date and passing |
pascalwengerter
approved these changes
Nov 19, 2019
| @@ -0,0 +1,5 @@ | |||
| %del{@tag_attributes.merge({:cite => options[:cite], :datetime => options[:datetime]})} | |||
There was a problem hiding this comment.
I'd prefer the @tag_attributes.merge([...]) stuff to be within a setup method in the del.rb, but that's a personal preference. Should be fine like this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #183: Adds
delcomponentChanges
Notes