-
-
Notifications
You must be signed in to change notification settings - Fork 43
Add iframe component. #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
%iframe{@tag_attributes} | ||
- if options[:text].nil? && block_given? | ||
= yield | ||
- else | ||
= options[:text] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
module Matestack::Ui::Core::Iframe | ||
class Iframe < Matestack::Ui::Core::Component::Static | ||
|
||
def setup | ||
@tag_attributes.merge!({ | ||
src: options[:src], | ||
height: options[:height], | ||
width: options[:width], | ||
srcdoc: options[:srcdoc] | ||
}) | ||
end | ||
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# matestack core component: Iframe | ||
|
||
Show [specs](/spec/usage/components/iframe_spec.rb) | ||
|
||
The HTML iframe tag implemented in ruby. | ||
|
||
## Parameters | ||
|
||
This component can take 3 configuration params and either yield content or display what gets passed to the `text` configuration param. | ||
|
||
#### # id (optional) | ||
Expects a string with all ids the `iframe` should have. | ||
|
||
#### # class (optional) | ||
Expects a string with all classes the `iframe` should have for styling purpose. | ||
|
||
#### # height (optional) | ||
Specifies the height of an `iframe`. | ||
|
||
#### # width (optional) | ||
Specifies the width of an `iframe`. | ||
|
||
#### # src | ||
pascalwengerter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Specifies the address of the document to embed in the `iframe` tag. | ||
|
||
#### # srcdoc | ||
Specifies the HTML content of the page to show in the inline frame. | ||
|
||
## Example 1: Yield a given block | ||
|
||
```ruby | ||
iframe id: "foo", class: "bar", src="https://www.demopage.com" do | ||
plain 'The browser does not support iframe.' | ||
end | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<iframe id="foo" class="bar" src="https://www.demopage.com"> | ||
The browser does not support iframe. | ||
</iframe> | ||
``` | ||
|
||
## Example 2: Render options[:text] param | ||
|
||
```ruby | ||
iframe id: "foo", class: "bar", src="https://www.demopage.com", text: 'The browser does not support iframe.' | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<iframe id="foo" class="bar" src="https://www.demopage.com"> | ||
The browser does not support iframe. | ||
</iframe> | ||
``` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
require_relative "../../support/utils" | ||
include Utils | ||
|
||
describe 'Iframe Component', type: :feature, js: true do | ||
|
||
it 'Example 1 - yield, no options[:text]' do | ||
|
||
class ExamplePage < Matestack::Ui::Page | ||
|
||
def response | ||
components { | ||
# simple iframe tag | ||
iframe src="https://www.demopage.com" do | ||
plain 'The browser does not support iframe.' | ||
end | ||
|
||
# enhanced iframe tag | ||
iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com", srcdoc="<p>Mate Stack UI!</p>" do | ||
plain 'The browser does not support iframe.' | ||
end | ||
} | ||
end | ||
|
||
end | ||
|
||
visit '/example' | ||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<iframe src="https://www.demopage.com">The browser does not support iframe.</iframe> | ||
<iframe id="my-id" class="my-class" src="https://www.demopage.com" srcdoc="<p>Mate Stack UI!</p>">The browser does not support iframe.</iframe> | ||
HTML | ||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
end | ||
|
||
it 'Example 2 - render options[:text]' do | ||
|
||
class ExamplePage < Matestack::Ui::Page | ||
|
||
def response | ||
components { | ||
# simple iframe tag | ||
iframe src="https://www.demopage.com", text: 'The browser does not support iframe.' | ||
|
||
# enhanced iframe tag | ||
iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com", | ||
srcdoc="<p>Mate Stack UI!</p>", text: 'The browser does not support iframe.' | ||
} | ||
end | ||
|
||
end | ||
|
||
visit '/example' | ||
|
||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<iframe src="https://www.demopage.com">The browser does not support iframe.</iframe> | ||
<iframe id="my-id" class="my-class" src="https://www.demopage.com" srcdoc="<p>Mate Stack UI!</p>">The browser does not support iframe.</iframe> | ||
HTML | ||
|
||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a lot of the attributes an iframe tag can have (see reference). See youtube or image component for reference on how to include multiple attributes into the
@tag_attributes
!