Document link param option, fixes #73 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasjabari
requested changes
Oct 23, 2019
bdlb77
reviewed
Oct 28, 2019
There was a problem hiding this comment.
It's a fairly small addition and I've never used it personally. But the <a> tag also accepts an attribute of title. I tested it out by adding it to your test and it had failed. So it may be good to add a link options to the component
def setup
@tag_attributes.merge!({ title: options[:title]})
end
...
|
@bdlb77 been there, done that 💪 and learned sth on the way, HTML can do sooo much things! |
…stack-ui-core into document_link_param_option
bdlb77
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #73: Document usage of params in link component
Changes