Skip to content

Fix view component #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2019
Merged

Fix view component #246

merged 2 commits into from
Oct 23, 2019

Conversation

pascalwengerter
Copy link
Contributor

Issue #240: Prepare for Rails 6

Changes

  • Remove inheritance from :cell to make zeitwerk work

Notes

  • Not sure if this is the right approach, but this component was causing trouble with Rails 6's zeitwerk

@pascalwengerter pascalwengerter changed the base branch from master to develop October 16, 2019 20:06
@jonasjabari
Copy link
Member

@pascalwengerter sorry for not seeing this before: the view component is obsolete for now. please adjust the PR to simply remove this component :)

@jonasjabari jonasjabari merged commit cfe888e into develop Oct 23, 2019
@pascalwengerter pascalwengerter deleted the fix_view_component branch October 25, 2019 14:05
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjabari jonasjabari Awaiting requested review from jonasjabari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwengerter @jonasjabari