Skip to content

add var component #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2019
Merged

add var component #247

merged 3 commits into from
Oct 17, 2019

Conversation

pascalwengerter
Copy link
Contributor

Issue #171: Add var component

Changes

  • Add component files
  • Add test
  • Add documents

marcoroth
marcoroth requested changes Oct 17, 2019
View reviewed changes
borref
borref approved these changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@borref borref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bdlb77
bdlb77 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@bdlb77 bdlb77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my end, also with tests 👍

@pascalwengerter
Copy link
Contributor Author

Thank you for the quick feedback everyone!

@pascalwengerter pascalwengerter merged commit 3bfbae8 into develop Oct 17, 2019
@pascalwengerter pascalwengerter deleted the add_var_component branch October 17, 2019 22:13
@pascalwengerter pascalwengerter mentioned this pull request Oct 17, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

@borref borref borref approved these changes

@bdlb77 bdlb77 bdlb77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@pascalwengerter @marcoroth @borref @bdlb77 @jonasjabari