-
-
Notifications
You must be signed in to change notification settings - Fork 43
ES5 transpiling #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES5 transpiling #254
Conversation
Hey @sigfriedCub1990! Thanks for your work here so far. I actually would ask you not to change the gem versions and only focus on the javascript adjustments :) Just to limit the scope of this PR. We will update the gems in other specific PRs. Thanks! |
No problems @jonasjabari, the only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sigfriedCub1990 looks very good to me!
Just two things that should happen before we can merge - could you
- Merge the latest
develop
branch into your repo - Delete your
Gemfile.lock
and only runbundle install
? We'll do the upgrade stuff (Rails 6 et al.) in a separate branch :-)
Hey @sigfriedCub1990 thank you for the clarifications! The thing with |
Hey @sigfriedCub1990, thank you for the fast reactions! I've now checked out your changes locally and the tests suite passes, so we're fine on that side. In the Do you have an idea how to fix that? Or am I missing a step somewhere? |
Let me check that after lunch :) |
Hey @pascalwengerter, it seems like there is partial support in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sigfriedCub1990 great work so far! We'll test the changes using browserstack and will let you know if IE does complain 😉
Issue #238: Older browsers support through ES5 transpiling and polyfills.
Changes
webpacker
to4.0
version..babelrc
to use the newly version ofbabeljs
and@babel/preset-env
babeljs
,@babel/preset-env
and necessary plugins.core-js
polyfills towebpack
entry file.Notes
ruby
developer probably I broke something 🙁, if that's the case I'll gladly downgrade the packages and I'll only upgrade thewebpacker
since that's the only critical package to upgrade.