Skip to content

Add figure tag #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2019
Merged

Add figure tag #258

merged 4 commits into from
Oct 27, 2019

Conversation

lumisce
Copy link
Contributor

@lumisce lumisce commented Oct 24, 2019

Issue #192: adds figure component

Changes

  • Add haml template
  • Add class
  • Add spec
  • Add docs
  • Add link to docs in readme

@lumisce lumisce changed the title Figure tag Add figure tag Oct 24, 2019
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @lumisce! Just two small things and we're good to merge :)

Copy link
Collaborator

@borref borref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny detail missing ;)

@borref borref self-requested a review October 26, 2019 08:26
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@pascalwengerter pascalwengerter merged commit 5b9a351 into matestack:develop Oct 27, 2019
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants