Adds unit test for video on page #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoBomfim thanks for the great work! The |
pascalwengerter
approved these changes
Oct 29, 2019
|
Uhu! Thanks for the all the support as well team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to target feature and bugfix requests to develop branch
Issue #159: Add tests for video component
Changes
Notes
Had a lot of trouble to get the tests working, mainly due to the gems failing at one degree or another. I'll list the main ones below just for reference:
The first one:
The second one:
And finally, the last one was the one I've mentioned on the chat