Skip to content

Add ins tag #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Add ins tag #260

merged 3 commits into from
Oct 27, 2019

Conversation

lumisce
Copy link
Contributor

@lumisce lumisce commented Oct 24, 2019

Issue #194: adds ins component

Changes

  • Add haml template
  • Add class
  • Add spec
  • Add docs
  • Add link to docs in readme

@lumisce lumisce changed the title Add the ins component Add ins tag Oct 24, 2019
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small step and we're good to go!

Copy link
Collaborator

@bdlb77 bdlb77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/basemate/matestack-ui-core/blob/develop/app/concepts/matestack/ui/core/fieldset/fieldset.rb

As @pascalwengerter had said with the #merge, take a look at the link above to get an idea of how to do write the #merge in the .rb file!

Copy link
Collaborator

@borref borref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, just a small tweak needed before shipping.

@lumisce lumisce requested a review from borref October 26, 2019 08:15
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thank you @lumisce!

@pascalwengerter pascalwengerter merged commit 2976948 into matestack:develop Oct 27, 2019
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants