Skip to content

Add object core component incl. docs&specs #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2019

Conversation

pascalwengerter
Copy link
Contributor

Issue #201: Object core component

Changes

  • Added core component in app/concepts/matestack/ui/core/object
  • Added related files in docs and spec folders

marcoroth
marcoroth previously approved these changes Nov 5, 2019
Copy link
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe you could add a test for testing all the possible parameters.

@pascalwengerter
Copy link
Contributor Author

Yeah @marcoroth I just tried to be lazy but thank you for calling me out on it 💃

@pascalwengerter pascalwengerter merged commit 9bf3c53 into develop Nov 6, 2019
@pascalwengerter pascalwengerter deleted the add_object_component branch November 6, 2019 20:15
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants